Skip to content

[Security] Use safe serialization and fix zmq setup for mooncake pipe #17192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

[Security] Use safe serialization and fix zmq setup for mooncake pipe #17192

merged 1 commit into from
Apr 25, 2025

Conversation

@russellb
Copy link
Member

@russellb russellb commented Apr 25, 2025

Resolves GHSA-hj4w-hm2g-p6w5

Part of #17128

Signed-off-by: Shangming Cai caishangming@linux.alibaba.com

@ShangmingCai @russellb
[Security] Use safe serialization and fix zmq setup for mooncake pipe
df7e880 
Signed-off-by: Shangming Cai <caishangming@linux.alibaba.com>
@russellb russellb mentioned this pull request Apr 25, 2025
Closed
2 tasks
@github-actions
Copy link

github-actions bot commented Apr 25, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 25, 2025
@ShangmingCai
Copy link
Contributor

ShangmingCai commented Apr 25, 2025

@russellb Thank you so much for your time and the help.

@russellb
Copy link
Member Author

russellb commented Apr 25, 2025

@russellb Thank you so much for your time and the help.

You're welcome! Thank you for writing the fix!

@russellb russellb enabled auto-merge (squash) April 25, 2025 15:50
@russellb russellb added this to the v0.8.5 milestone Apr 25, 2025
@russellb russellb merged commit a5450f1 into vllm-project:main Apr 25, 2025
67 checks passed
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@russellb @ShangmingCai @dbyoung18
[Security] Use safe serialization and fix zmq setup for mooncake pipe (…
0674030 
…vllm-project#17192)

Signed-off-by: Shangming Cai <caishangming@linux.alibaba.com>
Co-authored-by: Shangming Cai <caishangming@linux.alibaba.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@russellb @ShangmingCai @lk-chen
[Security] Use safe serialization and fix zmq setup for mooncake pipe (…
0d8a569 
…vllm-project#17192)

Signed-off-by: Shangming Cai <caishangming@linux.alibaba.com>
Co-authored-by: Shangming Cai <caishangming@linux.alibaba.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@russellb @ShangmingCai @adobrzyn
[Security] Use safe serialization and fix zmq setup for mooncake pipe (…
37f1340 
…vllm-project#17192)

Signed-off-by: Shangming Cai <caishangming@linux.alibaba.com>
Co-authored-by: Shangming Cai <caishangming@linux.alibaba.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@russellb @ShangmingCai
[Security] Use safe serialization and fix zmq setup for mooncake pipe (…
333e33b 
…vllm-project#17192)

Signed-off-by: Shangming Cai <caishangming@linux.alibaba.com>
Co-authored-by: Shangming Cai <caishangming@linux.alibaba.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

v0.8.5

Development

Successfully merging this pull request may close these issues.

3 participants

@russellb @ShangmingCai @mgoin